fix(depends): Avoid digits in archive file extension#4915
Merged
Conversation
Member
|
After this is applied, are |
Member
Author
Missed that. Thanks for reminding me. |
niheaven
reviewed
May 15, 2022
Member
niheaven
left a comment
There was a problem hiding this comment.
- Using
-replacemay be more readable - I've updated the test scripts and test cases, please review them
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Member
Author
The test scripts & cases works fine for me. Thank you. |
niheaven
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xxx.7z.001,xxx.7z.002, ....for example:
In this case.
some-app.7z.001extracts properly butsome-app.7z.002is treated as another independent archive, resulting in extraction error.