fix(scoop): Pass CLI arguments as string objects#4931
Merged
niheaven merged 4 commits intoScoopInstaller:developfrom May 17, 2022
Merged
fix(scoop): Pass CLI arguments as string objects#4931niheaven merged 4 commits intoScoopInstaller:developfrom
niheaven merged 4 commits intoScoopInstaller:developfrom
Conversation
Member
|
Just push a commit as review, and please check and test it. |
lewis-yeung
commented
May 17, 2022
lewis-yeung
commented
May 17, 2022
lewis-yeung
force-pushed
the
pass-args-as-strs
branch
from
127f231 to
174bda8
Compare
niheaven
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #4927.
Motivation and Context
Fix #4927.
How Has This Been Tested?
With this fix, the following calls in PowerShell work correctly and won't throw exceptions:
scoop install <app> -sandscoop update <app> -s.scoop '-v'.Checklist:
developbranch.