fix(config): Load config file before initialization#4932
Merged
niheaven merged 3 commits intoScoopInstaller:developfrom May 17, 2022
Merged
fix(config): Load config file before initialization#4932niheaven merged 3 commits intoScoopInstaller:developfrom
niheaven merged 3 commits intoScoopInstaller:developfrom
Conversation
The $scoopConfig is used to initialize several global variables like $scoopdir, but it was loaded after the initialization. The patch puts the loading before the initialization.
Member
|
Please finish the checklist for PR |
niheaven
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The $scoopConfig is used to initialize several global variables like $scoopdir, but
it was loaded after the initialization. The patch puts the loading before the initialization.
Motivation and Context
Fix #4918
How Has This Been Tested?
Use it in my scoop installation
Checklist:
developbranch.