feat(core): Add 'Get-Encoding()' function to fix missing webClient encoding#4956
feat(core): Add 'Get-Encoding()' function to fix missing webClient encoding#4956niheaven merged 5 commits intoScoopInstaller:developfrom
Conversation
…g ([ScoopInstaller#4956](ScoopInstaller#4956)) Add Get-Encoding function in core.ps1 close ScoopInstaller#4911
|
@rashil2000 Any review here will be helpful~ 😁 |
…g ([ScoopInstaller#4956](ScoopInstaller#4956)) Add Get-Encoding function in core.ps1 close ScoopInstaller#4911
|
Do you have some testing manifests? |
|
@niheaven ,Thanks for your reply. 😁 In #4911 (comment) , I use scoop install "https://raw.githubusercontent.com/ygguorun/scoop-bucket/master/bucket/PDFPatcher.json", and this manifest - DoveBoy/Apps/pdfpatcher has the |
|
|
|
@niheaven I used it for Could you please provider the way to test the |
|
Checkout this branch and cd in any bucket, run |
…ing (ScoopInstaller#4956) Add `Get-Encoding` function in core.ps1 closes: ScoopInstaller#4911 ScoopInstaller#4324 Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
…ing (ScoopInstaller#4956) Add `Get-Encoding` function in core.ps1 closes: ScoopInstaller#4911 ScoopInstaller#4324 Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
|
@niheaven Thanks for pointing out the problem, I think it's fixed now. 😁 |
|
Some tweaks, and please test it @yi-Xu-0100 |
|
@niheaven Thanks for adding the judgment for null values, but there is something we need to revert. If we use So I re-split the expression to handle the case where |
|
Aha, right? Okay, I'll test it tomorrow and it seems stable enough now. |
Add Get-Encoding function in core.ps1
Description
Motivation and Context
Closes #4911 #4324
Relates to #4911 #4324
How Has This Been Tested?
Checklist:
developbranch.