fix(scoop-uninstall): run pre_uninstall before testing running processes#4962
Merged
chawyehsu merged 5 commits intoScoopInstaller:developfrom Jun 3, 2022
beer-psi:prerm_before_running_tests
Merged
fix(scoop-uninstall): run pre_uninstall before testing running processes#4962chawyehsu merged 5 commits intoScoopInstaller:developfrom beer-psi:prerm_before_running_tests
chawyehsu merged 5 commits intoScoopInstaller:developfrom
beer-psi:prerm_before_running_tests
Conversation
Contributor
Author
|
One question: Is a CHANGELOG.md entry required, considering |
Member
|
Add |
Contributor
Author
|
Alright, I've done that |
chawyehsu
reviewed
Jun 2, 2022
niheaven
reviewed
Jun 2, 2022
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
chawyehsu
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Execute the
pre_uninstallhook before other uninstallation preparation work, namelytest_running_processMotivation and Context
Closes #4961
Motivations
pre_uninstallscript should handle teardown work such as stopping services, so that the uninstallation process isn't blocked by running processes.post_uninstall, which is run at the very end of the uninstallation process.How Has This Been Tested?
Checklist:
developbranch.