Skip to content

refactor(manifest): Rename 'Find-Manifest()' to 'Get-Manifest()'#4966

Merged
niheaven merged 2 commits intodevelopfrom
refactor-get-maifest
Jun 7, 2022
Merged

refactor(manifest): Rename 'Find-Manifest()' to 'Get-Manifest()'#4966
niheaven merged 2 commits intodevelopfrom
refactor-get-maifest

Conversation

@niheaven
Copy link
Copy Markdown
Member

@niheaven niheaven commented Jun 4, 2022

Description

  • Move bucket.ps1/Find-Manifest() to manifest.ps1/Get-Manifest()
  • Embed parse_app() into Get-Manifest()
  • Enclose parse_app()'s RegEx with ^ and $

Motivation and Context

How Has This Been Tested?

  • scoop cat
  • scoop info
  • scoop home
  • scoop install
  • test.ps1

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven
Copy link
Copy Markdown
Member Author

niheaven commented Jun 6, 2022

Merge and test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants