refactor(scoop-search): Output PSObject, use API token#4997
Merged
rashil2000 merged 8 commits intodevelopfrom Jun 21, 2022
Merged
refactor(scoop-search): Output PSObject, use API token#4997rashil2000 merged 8 commits intodevelopfrom
rashil2000 merged 8 commits intodevelopfrom
Conversation
niheaven
requested changes
Jun 20, 2022
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Member
|
Should the empty 'Binaries' be removed? |
Member
Author
|
I tried, but a hashtable array needs all fields to exist otherwise even those results who have Binaries will not show up 😅 |
niheaven
approved these changes
Jun 21, 2022
slaughtering
pushed a commit
to slaughtering/scoop
that referenced
this pull request
Jul 7, 2022
…r#4997) * refactor(scoop-search): Output PSObject, use API token * warn about parsing error * Update CHANGELOG.md * Update scoop-search.ps1 * Apply suggestions from code review Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> * separate lines Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
searchto return PowerShell objects.gh_tokenexists.Motivation and Context
Closes #4202
Closes #4574
Closes #4852
Closes #3853
Relates to #3446
How Has This Been Tested?
Checklist:
developbranch.