Skip to content

feat(scoop-import): Import a Scoop installation from JSON#5014

Merged
rashil2000 merged 7 commits intodevelopfrom
feat-import
Jun 24, 2022
Merged

feat(scoop-import): Import a Scoop installation from JSON#5014
rashil2000 merged 7 commits intodevelopfrom
feat-import

Conversation

@rashil2000
Copy link
Copy Markdown
Member

@rashil2000 rashil2000 commented Jun 22, 2022

Description

Awesome new feature of Scoop! 🎉🎊

Export to and import a Scoop installation from a JSON file.

Motivation and Context

Closes #3934

How Has This Been Tested?

scoop export -c > Desktop\scoopfile.json
scoop import Desktop\scoopfile.json

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Copy link
Copy Markdown
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the import feature, but it's okay in static reviews.

Comment thread libexec/scoop-import.ps1 Outdated
@rashil2000
Copy link
Copy Markdown
Member Author

@niheaven anything remaining here?

@rashil2000 rashil2000 merged commit c4d1b9c into develop Jun 24, 2022
@rashil2000 rashil2000 deleted the feat-import branch June 24, 2022 05:42
@zStruCat
Copy link
Copy Markdown
Contributor

zStruCat commented Jul 1, 2022

One minor issue:
Regarding
scoop export -c > Desktop\scoopfile.json
"-c" option seems not covered in scoop help export.
I presume it means create? But the command does create a file without "-c".

@rashil2000
Copy link
Copy Markdown
Member Author

Thanks for noticing @zStruCat! It was a typo and I've fixed it

slaughtering pushed a commit to slaughtering/scoop that referenced this pull request Jul 7, 2022
…ller#5014)

* feat(scoop-export): Export Scoop installation in JSON

* optimize

* yesss done

* complete

* Update CHANGELOG.md

* Add suggestions from code review

* fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants