fix(scoop-import): Use foreach instead of ForEach-Object for nullity check#5034
Merged
rashil2000 merged 7 commits intoScoopInstaller:developfrom Jul 7, 2022
Merged
fix(scoop-import): Use foreach instead of ForEach-Object for nullity check#5034rashil2000 merged 7 commits intoScoopInstaller:developfrom
foreach instead of ForEach-Object for nullity check#5034rashil2000 merged 7 commits intoScoopInstaller:developfrom
Conversation
Member
|
I've made some tweaks:
|
foreach instead of ForEach-Object for nullity check
Contributor
Author
I agree that "if a bucket already exists, we want to show an error while importing", but currently the resulted warning and hint is misleading in this context, especially: |
rashil2000
reviewed
Jul 6, 2022
Contributor
Author
rashil2000
reviewed
Jul 6, 2022
Make warning clearer Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
slaughtering
pushed a commit
to slaughtering/scoop
that referenced
this pull request
Jul 7, 2022
…ity check (ScoopInstaller#5034) * Add nullity check and alread_in_local_bucket check * update CHANGELOG * Use foreach instead of ForEach-Object * changelog * update help * refine the info and warning when adding an already-added bucket * Update lib/buckets.ps1 Make warning clearer Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> Co-authored-by: Rashil Gandhi <rashil2000@gmail.com> Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Check whether the wanted property of bucket is null.
Check if the to-be-imported bucket is already added locally
Context
Closes #5033