fix(core): Avoid deadlock in Invoke-ExternalCommand#5064
Merged
niheaven merged 5 commits intoScoopInstaller:developfrom Jul 25, 2022
Merged
fix(core): Avoid deadlock in Invoke-ExternalCommand#5064niheaven merged 5 commits intoScoopInstaller:developfrom
Invoke-ExternalCommand#5064niheaven merged 5 commits intoScoopInstaller:developfrom
Conversation
lewis-yeung
changed the title
Invoke-ExternalCommandInvoke-ExternalCommand
lewis-yeung
force-pushed
the
avoid-deadlock
branch
from
79bc9f3 to
fc9d646
Compare
niheaven
requested changes
Jul 25, 2022
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
niheaven
approved these changes
Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove a deadlock potential in the function
Invoke-ExternalCommand. See MS docs for details.Checklist:
developbranch.