feat(core): Improve argument concatenation in Invoke-ExternalCommand

[lewis-yeung]

Description

Use ArgumentList in PowerShell 6.1 and later (built on .NET Core 2.1+), otherwise escape arguments using the general MSVC Runtime's rules in older versions.

In the past, due to the arbitraryness of arguments, we are not able to handle all cases where arguments may contain spaces, quotes or other special characters for every automatic installer script that uses Invoke-ExternalCommand. With this change, we don't have to escape arguments manually for most external commands any more. But for the following exceptions who basically don't follow the general MSVC Runtime's rules of parsing command line, just simply concatenate arguments with spaces to build the argument list string, which means we have to escape arguments manually for them: (case insensitive)

• Well-known executables: cmd.exe, cscript.exe, wscript.exe and msiexec.exe.
• Files with these suffixes: .bat, .cmd, .js, .vbs and .wsf.

Ref: MS docs

Checklist:

• I have read the Contributing Guide.
• I have ensured that I am targeting the develop branch.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.
• I have added an entry in the CHANGELOG.

[niheaven]

LGTM, but may need more tests in develop

[niheaven]

And thank @issaclin32 for the fixes of incompatibility. 😭

[chawyehsu]

Can we revert this? It's a broken implementation.

[niheaven]

Revert it in develop, do a release, and then try to make it more robust. Is it okay? @ScoopInstaller/maintainers @lewis-yeung

[lewis-yeung]

@niheaven Seems to make sense. But what about those manifests that have already been adjusted for this feature? Or if you already have an idea on how to make a bidirectionally compatible implementation?