feat(core): Create no window by default in Invoke-ExternalCommand

[lewis-yeung]

Description

Support a new -NoWindow switch which indicates the process should be started without creating a new window to contain it. This switch cannot go with -RunAs.

EDITED: So stupid that I missed the switch in this PR even though I wrote the description above. 😭

Checklist:

• I have read the Contributing Guide.
• I have ensured that I am targeting the develop branch.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.
• I have added an entry in the CHANGELOG.

[chawyehsu]

This breaks my install/uninstall scripts for my dorado/msys2-cn. With this forced CreateNoWindow I keep getting error code 3840 while triggering msys2-cn installation. 2 hours were wasted for me finding out this cause. Can we have a switch to stop the forced NoWindow or how could I fix this on my side?

[niheaven]

I'm planning to merge #5124 which refactor Invoke-ExternalCommand(), and will add a switch to disable (or make it disabled by default) -CreateNoWindow.

The default behavior of Invoke-ExternalCommand() stops redirecting default output to a variable which could be used later.

[lewis-yeung]

@chawyehsu So sorry that I made a stupid mistake in this PR... 🤦🏻

Scoop/lib/core.ps1

Line 524 in 34da850

$Process.StartInfo.CreateNoWindow = $true

A -NoWindow switch should have been added for Invoke-ExternalCommand. I don't know why I didn't add it even though I did write the relevant description at that time:

Support a new -NoWindow switch which indicates the process should be started without creating a new window to contain it.

@niheaven You're right, CreateNoWindow should not be $true by default, though I found that CreateNoWindow never affects GUI apps.