fix(psmodules): Remove folder recursively when unlinking previous module path

[AkariiinMKII]

Description

Add a -Recurse parameter to Remove-Item cmdlet when unlinking psmodule path.

Motivation and Context

• Relates to [Bug] Confirm required when updating PowerShell module apps #5126

How Has This Been Tested?

I've tested my codes by performing update for the same app, everything seems ok

Linking ~\scoop\modules\WhoAteMyRAM => ~\scoop\apps\WhoAteMyRAM\current
WARN  ~\scoop\modules\WhoAteMyRAM already exists. It will be replaced.
Running post_install script...
'WhoAteMyRAM' (1.0.10) was installed successfully!

Changes may effect:

Scoop/libexec/scoop-uninstall.ps1

Line 85 in d63b7d6

uninstall_psmodule $manifest $refdir $global

Scoop/lib/install.ps1

Line 60 in 4a31bd3

install_psmodule $manifest $dir $global

Checklist:

• I have read the Contributing Guide.
• I have ensured that I am targeting the develop branch.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.
• I have added an entry in the CHANGELOG.

[rashil2000]

Could this also solve #4844?

[AkariiinMKII]

Could this also solve #4844?

Nope I guess, his issue happens in uninstallation process, while mine happens in installation process.

[rashil2000]

Which PS module do you face this error in? Does it happen in any/all PS modules?

[AkariiinMKII]

Which PS module do you face this error in? Does it happen in any/all PS modules?

Yes, it happens in all modules.

[rashil2000]

I am unable to repro this issue:

[AkariiinMKII]

I am unable to repro this issue:

Maybe it's because of PS version, it appears in PS 5.1, which is included in Win 10 by default.

[AkariiinMKII]

There is another solution that we run uninstall_psmodule during update process, even the warning message won't appear if we act like this, but without -Recurse parameter, confirm is still required if there is conflict folder, which is not empty, while installing.
Maybe we need to change both?

[rashil2000]

Right, the prompt appears in PS 5.1

This should fix it.