Skip to content

builds(auto-pr): Add CommitMessageFormat option#5171

Merged
niheaven merged 10 commits intoScoopInstaller:developfrom
yi-Xu-0100:develop
Oct 14, 2022
Merged

builds(auto-pr): Add CommitMessageFormat option#5171
niheaven merged 10 commits intoScoopInstaller:developfrom
yi-Xu-0100:develop

Conversation

@yi-Xu-0100
Copy link
Copy Markdown
Contributor

@yi-Xu-0100 yi-Xu-0100 commented Oct 1, 2022

Description

Add CommitMessageFormat option to support custom commit message for GitHub action.

Such as: CommitMessageFormat : chore: Upgrade <app> to version <version>

Motivation and Context

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Comment thread bin/auto-pr.ps1 Outdated
@yi-Xu-0100 yi-Xu-0100 requested a review from lewis-yeung October 2, 2022 02:09
lewis-yeung
lewis-yeung previously approved these changes Oct 2, 2022
@niheaven
Copy link
Copy Markdown
Member

niheaven commented Oct 6, 2022

Change title and move changelog item to builds.

@yi-Xu-0100 yi-Xu-0100 changed the title feat(auto-pr): add CommitMessageFormat option builds(auto-pr): Add CommitMessageFormat option Oct 7, 2022
@yi-Xu-0100 yi-Xu-0100 requested a review from lewis-yeung October 7, 2022 08:14
@yi-Xu-0100
Copy link
Copy Markdown
Contributor Author

@niheaven The changelog has been updated. 😁

lewis-yeung
lewis-yeung previously approved these changes Oct 13, 2022
@yi-Xu-0100
Copy link
Copy Markdown
Contributor Author

@lewis-yeung @niheaven

I found a bug that $version was prepared later and will lose the version information in commitMessage. and I push a new commit(612169e) to fix it. 😅

@niheaven niheaven merged commit 512ab44 into ScoopInstaller:develop Oct 14, 2022
github-actions Bot pushed a commit to pukkandan/Scoop that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants