builds(checkhashes): Use correct version number if UseCache#5240
Merged
builds(checkhashes): Use correct version number if UseCache#5240
UseCache#5240Conversation
niheaven
changed the title
UseCacheUseCache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix is concerned with GitHubActions, which downloads file twice if there's no autoupdate hash extraction.
Motivation and Context
When using
checkhashes, the actual files are downloaded and hash checked, but the version number in cached file isHASH_CHECK, and in GHA,checkhashesandcheckverboth download files and don't reuse them. So changecheckhashes's switch to let reuse.How Has This Been Tested?
Before:
After:
Checklist:
developbranch.