fix Unable to download release assets from private GitHub repositories#5361
Merged
rashil2000 merged 2 commits intoScoopInstaller:developfrom Feb 25, 2023
polytech-com:develop
Merged
fix Unable to download release assets from private GitHub repositories#5361rashil2000 merged 2 commits intoScoopInstaller:developfrom polytech-com:develop
rashil2000 merged 2 commits intoScoopInstaller:developfrom
polytech-com:develop
Conversation
rashil2000
previously approved these changes
Jan 30, 2023
Contributor
Author
|
It seems it needs workflow approval? |
r15ch13
previously approved these changes
Feb 25, 2023
Member
|
Please rebase this PR onto develop to fix the changelog merge conflict |
jeppefrandsen
dismissed stale reviews from r15ch13 and rashil2000
via
4b6428b
Contributor
Author
|
@r15ch13 should be ready now 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub has changed the required API headers lately causing download of release assets from private GitHub repositories not to work. See https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28
Motivation and Context
Closes #5357
How Has This Been Tested?
Local tested with public (oh-my-posh package) and private GitHub repository download
Checklist:
developbranch.