Skip to content

fix(core): Fix scripts' calling parameters#5365

Merged
niheaven merged 3 commits intodevelopfrom
fix-scoop-import
Feb 26, 2023
Merged

fix(core): Fix scripts' calling parameters#5365
niheaven merged 3 commits intodevelopfrom
fix-scoop-import

Conversation

@niheaven
Copy link
Copy Markdown
Member

@niheaven niheaven commented Jan 30, 2023

Description

Direct calling of scoop scripts makes getopt() error, since it bypassed PowerShell's arguments parsing.

So use splatting to pass arguments correctly (w/o splitting by space).

Motivation and Context

How Has This Been Tested?

Should be fine and tested by scoop import

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven requested a review from rashil2000 February 25, 2023 12:43
@niheaven niheaven merged commit 3f11454 into develop Feb 26, 2023
@niheaven niheaven deleted the fix-scoop-import branch February 26, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants