Skip to content

fix(git): set HTTP(S)_PROXY only in process scope to prevent race condition#5436

Merged
niheaven merged 2 commits intodevelopfrom
fix-git-parallel-proxy
Mar 20, 2023
Merged

fix(git): set HTTP(S)_PROXY only in process scope to prevent race condition#5436
niheaven merged 2 commits intodevelopfrom
fix-git-parallel-proxy

Conversation

@r15ch13
Copy link
Copy Markdown
Member

@r15ch13 r15ch13 commented Mar 18, 2023

Description

Prevents leaking HTTP(S)_PROXY env vars to current sessions after Invoke-Git in parallel by scoop update

Motivation and Context

Closes #5435

How Has This Been Tested?

Used mitmproxy locally to confirm proxy settings are working properly

# disable SSL verification for testing
git config --global http.sslVerify false

# enable proxy settings in scoop
scoop config proxy http://localhost:8080

# run mitmweb
mitmweb

# update scoop and check if everything gets updated properly
./bin/scoop.ps1 update

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Copy link
Copy Markdown
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the chglog is needed.

@r15ch13 r15ch13 force-pushed the fix-git-parallel-proxy branch from a6d75da to b5eee91 Compare March 20, 2023 15:03
@niheaven niheaven merged commit 682a1e2 into develop Mar 20, 2023
@niheaven niheaven deleted the fix-git-parallel-proxy branch March 20, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants