fix(git): set HTTP(S)_PROXY only in process scope to prevent race condition#5436
Merged
fix(git): set HTTP(S)_PROXY only in process scope to prevent race condition#5436
Conversation
niheaven
reviewed
Mar 20, 2023
Member
niheaven
left a comment
There was a problem hiding this comment.
LGTM, and the chglog is needed.
a6d75da to
b5eee91
Compare
niheaven
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents leaking HTTP(S)_PROXY env vars to current sessions after
Invoke-Gitin parallel byscoop updateMotivation and Context
Closes #5435
How Has This Been Tested?
Used mitmproxy locally to confirm proxy settings are working properly
Checklist:
developbranch.I have updated the tests accordingly.