fix(env): Apply env immediately by SendMessageTimeout#5452
Merged
niheaven merged 2 commits intoScoopInstaller:developfrom Apr 7, 2023
Merged
fix(env): Apply env immediately by SendMessageTimeout#5452niheaven merged 2 commits intoScoopInstaller:developfrom
SendMessageTimeout#5452niheaven merged 2 commits intoScoopInstaller:developfrom
Conversation
niheaven
approved these changes
Apr 6, 2023
Member
It seems to be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the problem caused by the merge of #5395, mentioned in 5424#issuecomment-1479734238, similar to ScoopInstaller/Install#49.
Use
SendMessageTimeoutin user32 to update the env in explorer.exe, and then the new env will be used in new process of powershell/cmd.I have tested it in some cases and it works fine. I can't guarantee that all situations will be known to me. For example, a known issue is that if you use Windows Terminal, updating env in one tab does not update env in another tab of the same window, as mentioned in microsoft/terminal#14999.