Skip to content

fix(update/uninstall): Remove items from PATH correctly#5833

Merged
niheaven merged 2 commits intodevelopfrom
fix-env_rm_path
Mar 20, 2024
Merged

fix(update/uninstall): Remove items from PATH correctly#5833
niheaven merged 2 commits intodevelopfrom
fix-env_rm_path

Conversation

@niheaven
Copy link
Copy Markdown
Member

@niheaven niheaven commented Mar 20, 2024

Description

Remove PATH correctly.

  • Handle '.' in env_rm_path
  • Remove correct dir if junction is used (a.k.a. remove ...\current instead of ...\x.x.x during updating

Motivation and Context

Relates to #4550

How Has This Been Tested?

Before:
image

After:
image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven changed the title fix(uninstall): Remove items from PATH correctly fix(update/uninstall): Remove items from PATH correctly Mar 20, 2024
Copy link
Copy Markdown
Member

@chawyehsu chawyehsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niheaven niheaven merged commit 3186fef into develop Mar 20, 2024
@niheaven niheaven deleted the fix-env_rm_path branch March 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants