fix(shim): Run JAR file from app's root directory#5872
Merged
Conversation
Member
Author
|
I'm not sure if |
Member
|
Why WSL check? |
Member
Author
|
WSL couldn't recognize |
1 task
Member
Author
|
Some use cases: ScoopInstaller/Main#5702, ScoopInstaller/Main#5704 |
Member
|
I recognize the usefulness of this feature, but still don't get the WSL part - do we really need to handle the use case where bash scripts (meant to run in Git Bash etc.) would be run inside WSL Bash? Wouldn't that lead to additional problems (w.r.t to finding the correct binaries like java.exe etc.)? |
Member
Author
|
WSL shares PATH with the host machine, so if you install Java and can run in pwsh, you can run it in WSL too. That's why we should consider such cases. |
rashil2000
approved these changes
Apr 11, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For Java apps, the working directory should be apps' root directory since config files are normally located beside
.jar.Checklist:
developbranch.