fix(autoupdate): Fix bug that 'WebClient' doesn't auto-extract 'gzip'#5901
Merged
fix(autoupdate): Fix bug that 'WebClient' doesn't auto-extract 'gzip'#5901
Conversation
Member
|
Thanks for this! |
tech189
approved these changes
Apr 17, 2024
Member
tech189
left a comment
tech189
left a comment
There was a problem hiding this comment.
LGTM, tested in Powershell 7.4.1 and Powershell 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When accessing 'www.python.com',
WebClientdoes not automatically extractgzip. This pull request checks if the downloaded content is a gzip file and extracts it.PS. We could use
Invoke-WebRequestinstead ofWebClientto download web pages and other files.Motivation and Context
checkveris failing Main#5709checkveris failing Versions#1683How Has This Been Tested?
Checklist:
developbranch.