Skip to content

fix(json): Serialize jsonpath return#5921

Merged
niheaven merged 4 commits intoScoopInstaller:developfrom
chawyehsu:patch-1
Apr 26, 2024
Merged

fix(json): Serialize jsonpath return#5921
niheaven merged 4 commits intoScoopInstaller:developfrom
chawyehsu:patch-1

Conversation

@chawyehsu
Copy link
Copy Markdown
Member

@chawyehsu chawyehsu commented Apr 24, 2024

This may break checkver of some manifests if they leverage the old format of return. We can update those manifests once found.

Description

Motivation and Context

Closes #5920

Relates to #XXXX

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
@niheaven
Copy link
Copy Markdown
Member

In the given example, json_path will yield [[17,50,19,0],"87c7b863-4be0-4324-ab84-dfde19bccc18",[17,50,19,0],"12ad915b-781e-4859-aedb-2d1e51f9d384"]. Can this be easily handled subsequently?

@chawyehsu
Copy link
Copy Markdown
Member Author

The output will be handled by the specified regex next to the jsonpath, so it's up to the manifest author. I believe it'd help to write simpler regex by yielding such clean json output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants