fix(core): Search for Git executable instead of any cmdlet#5998
Merged
niheaven merged 2 commits intoScoopInstaller:developfrom Jun 7, 2024
Merged
fix(core): Search for Git executable instead of any cmdlet#5998niheaven merged 2 commits intoScoopInstaller:developfrom
niheaven merged 2 commits intoScoopInstaller:developfrom
Conversation
Before this commit, if a user had a custom alias or function for `git` specified in their PowerShell profile, `Get-HelperPath` would return path to the PowerShell module where the function is defined instead of path to the actual Git binary.
3 tasks
niheaven
reviewed
Jun 4, 2024
Member
|
Hmm, would you please sign your commit? |
Contributor
Author
|
Nope. If you want the commit, merge it (or just make the change in your own commit, I don't care about attribution), can't be bothered to setup a signature. |
5 tasks
niheaven
pushed a commit
that referenced
this pull request
Jun 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5979
Motivation and Context
Before this commit, if a user had a custom alias or function for
gitspecified in their PowerShell profile,Get-HelperPathwould return path to the PowerShell module where the function is defined instead of path to the actual Git binary.How Has This Been Tested?
Tested interactively, the code seems reasonably obvious to me. To test the fix, run the following snippet:
Without this PR, the invocation results in the folowing error:
Checklist:
developbranch.