fix(shim): properly check `wslpath`/`cygpath` command first by sitiom · Pull Request #6114 · ScoopInstaller/Scoop

sitiom · 2024-08-19T10:00:54Z

Description

Do not suppress stderr for commands, only suppress output when checking for wslpath/cygpath commands first.

Motivation and Context

Closes #6112

How Has This Been Tested?

wcurl at ScoopInstaller/Main#6117

Before: Error, no output

After: now returns an error with the output

Checklist:

I have read the Contributing Guide.
I have ensured that I am targeting the develop branch.
I have updated the documentation accordingly.
I have updated the tests accordingly.
I have added an entry in the CHANGELOG.

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>

Note: - Passing arguments to mingw/cygwin bash does not work without `bash -c` - Not much I can do for PowerShell: https://github.com/Azure/azure-cli/blob/dev/doc/quoting-issues-with-powershell.md

* fix (decompress): `Expand-7zipArchive` only delete temp dir / `$extractDir` if it is empty (#6092) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> * refactor(download): Move download-related functions to 'download.ps1' (#6095) * fix(download): Fallback to default downloader when aria2 fails (#4292) * fix(commands): Handling broken aliases (#6141) * fix(shim): properly check `wslpath`/`cygpath` command first (#6114) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> * fix(scoop-bucket): Add missing import for `no_junction` envs (#6181) Signed-off-by: Chawye Hsu <su+git@chawyehsu.com> * docs(chglog): Update to 0.5.3 (#6258) * perf(shim): Update kiennq-shim to v3.1.2 (#6261) * fix(decompress): Replace deprecated 7ZIPEXTRACT_USE_EXTERNAL config (#6327) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> * fix(scoop-uninstall): Fix uninstaller does not gain Global state (#6430) * global arg * changelog * refactor(Get-Manifest): Select actual source for manifest (#6142) * first step * Revert "first step" This reverts commit c5907c3. * refactor(Get-Manifest): Select actual source for installed manifest * rework sub-commands, `scoop-depends` is NOT working at this stage * URI manifest * opt * deprecated manifest * source of manifests * source of manifest pt2 - Mark URI(path/URL/UNC/etc.) query as standalone manifest - Drop `installed` and `available update` items for [query] and [installed] are different sources. * remove variable preventing I forget it * scoop-info: fix source of manifest on bucket * fix `scoop-depends` * Fix Standalone and Source detection * fix global install * Fix scoop-cat, scoop-home - Query for remote manifest * scoop-list: info +deprecated * manifest: Fix first selected manifest * gramma.. * Fix 61b3259 * length * fix(scoop-depends-tests): Mocking `USE_EXTERNAL_7ZIP` as $false (#6431) * fix(scoop-depends-tests): Mocking `USE_EXTERNAL_7ZIP` as $false to avoding error when it is $true * CHANGELOG * feat(autoupdate): GitHub predefined hashes support (#6416) * feat(autoupdate): predefined hash case for GitHub - Remove `sha256:` prefix in `format_hash()` - Add GitHub support in `get_hash_for_app()` Close #6381 * doc(chglog): GitHub auto hash update * fix(autoupdate): remove prefix only * docs(CHANGELOG): Update to 0.5.3 (#6432) * docs(CHANGELOG): Update to 0.5.3 * 6416 --------- Signed-off-by: Chawye Hsu <su+git@chawyehsu.com> Co-authored-by: Olav Rønnestad Birkeland <6450056+o-l-a-v@users.noreply.github.com> Co-authored-by: kiennq <kien.n.quang@gmail.com> Co-authored-by: HUMORCE <humorce@outlook.com> Co-authored-by: Ryan <sitiom@proton.me> Co-authored-by: Chawye Hsu <su+git@chawyehsu.com> Co-authored-by: Bassel Rachid <101208715+basselworkforce@users.noreply.github.com> Co-authored-by: Wordless Echo <wordless@echo.moe>

…taller#6114) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>

* chore(release): Bump to version 0.5.3 (ScoopInstaller#6257) * fix (decompress): `Expand-7zipArchive` only delete temp dir / `$extractDir` if it is empty (ScoopInstaller#6092) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> * refactor(download): Move download-related functions to 'download.ps1' (ScoopInstaller#6095) * fix(download): Fallback to default downloader when aria2 fails (ScoopInstaller#4292) * fix(commands): Handling broken aliases (ScoopInstaller#6141) * fix(shim): properly check `wslpath`/`cygpath` command first (ScoopInstaller#6114) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> * fix(scoop-bucket): Add missing import for `no_junction` envs (ScoopInstaller#6181) Signed-off-by: Chawye Hsu <su+git@chawyehsu.com> * docs(chglog): Update to 0.5.3 (ScoopInstaller#6258) * perf(shim): Update kiennq-shim to v3.1.2 (ScoopInstaller#6261) * fix(decompress): Replace deprecated 7ZIPEXTRACT_USE_EXTERNAL config (ScoopInstaller#6327) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> * fix(scoop-uninstall): Fix uninstaller does not gain Global state (ScoopInstaller#6430) * global arg * changelog * refactor(Get-Manifest): Select actual source for manifest (ScoopInstaller#6142) * first step * Revert "first step" This reverts commit c5907c3. * refactor(Get-Manifest): Select actual source for installed manifest * rework sub-commands, `scoop-depends` is NOT working at this stage * URI manifest * opt * deprecated manifest * source of manifests * source of manifest pt2 - Mark URI(path/URL/UNC/etc.) query as standalone manifest - Drop `installed` and `available update` items for [query] and [installed] are different sources. * remove variable preventing I forget it * scoop-info: fix source of manifest on bucket * fix `scoop-depends` * Fix Standalone and Source detection * fix global install * Fix scoop-cat, scoop-home - Query for remote manifest * scoop-list: info +deprecated * manifest: Fix first selected manifest * gramma.. * Fix 61b3259 * length * fix(scoop-depends-tests): Mocking `USE_EXTERNAL_7ZIP` as $false (ScoopInstaller#6431) * fix(scoop-depends-tests): Mocking `USE_EXTERNAL_7ZIP` as $false to avoding error when it is $true * CHANGELOG * feat(autoupdate): GitHub predefined hashes support (ScoopInstaller#6416) * feat(autoupdate): predefined hash case for GitHub - Remove `sha256:` prefix in `format_hash()` - Add GitHub support in `get_hash_for_app()` Close ScoopInstaller#6381 * doc(chglog): GitHub auto hash update * fix(autoupdate): remove prefix only * docs(CHANGELOG): Update to 0.5.3 (ScoopInstaller#6432) * docs(CHANGELOG): Update to 0.5.3 * 6416 --------- Signed-off-by: Chawye Hsu <su+git@chawyehsu.com> Co-authored-by: Olav Rønnestad Birkeland <6450056+o-l-a-v@users.noreply.github.com> Co-authored-by: kiennq <kien.n.quang@gmail.com> Co-authored-by: HUMORCE <humorce@outlook.com> Co-authored-by: Ryan <sitiom@proton.me> Co-authored-by: Chawye Hsu <su+git@chawyehsu.com> Co-authored-by: Bassel Rachid <101208715+basselworkforce@users.noreply.github.com> Co-authored-by: Wordless Echo <wordless@echo.moe> * fix(autoupdate): Skiping github mode while hash.url already set --------- Signed-off-by: Chawye Hsu <su+git@chawyehsu.com> Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Co-authored-by: Olav Rønnestad Birkeland <6450056+o-l-a-v@users.noreply.github.com> Co-authored-by: kiennq <kien.n.quang@gmail.com> Co-authored-by: Ryan <sitiom@proton.me> Co-authored-by: Chawye Hsu <su+git@chawyehsu.com> Co-authored-by: Bassel Rachid <101208715+basselworkforce@users.noreply.github.com> Co-authored-by: Wordless Echo <wordless@echo.moe>

fix(shim): properly check wslpath/cygpath command

8ddefe7

sitiom mentioned this pull request Aug 19, 2024

wcurl: Update manifest ScoopInstaller/Main#6117

Open

1 task

Update CHANGELOG.md

d803601

niheaven reviewed Aug 19, 2024

View reviewed changes

Comment thread lib/core.ps1 Outdated

sitiom and others added 2 commits August 19, 2024 18:55

Update lib/core.ps1

e182062

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>

Properly escape special characters & quote arguments

3daf211

Note: - Passing arguments to mingw/cygwin bash does not work without `bash -c` - Not much I can do for PowerShell: https://github.com/Azure/azure-cli/blob/dev/doc/quoting-issues-with-powershell.md

sitiom force-pushed the patch-1 branch from 464350a to 3daf211 Compare August 20, 2024 04:56

Merge branch 'develop' into patch-1

b030aa3

niheaven approved these changes Oct 9, 2024

View reviewed changes

niheaven merged commit 7a309a1 into ScoopInstaller:develop Oct 9, 2024

sitiom deleted the patch-1 branch October 9, 2024 11:41

niheaven mentioned this pull request Dec 30, 2024

chore(release): Bump to version 0.5.3 #6257

Merged

HUMORCE pushed a commit to HUMORCE/Scoop that referenced this pull request Aug 11, 2025

fix(shim): properly check wslpath/cygpath command first (ScoopIns…

9b0fbd8

…taller#6114) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(shim): properly check `wslpath`/`cygpath` command first#6114

fix(shim): properly check `wslpath`/`cygpath` command first#6114
niheaven merged 5 commits intoScoopInstaller:developfrom
sitiom:patch-1

sitiom commented Aug 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sitiom commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How Has This Been Tested?

Checklist:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sitiom commented Aug 19, 2024 •

edited

Loading