Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

add rectangle support (rebase version)#1450

Merged
sebholstein merged 1 commit into
masterfrom
tim-rectangle
Jul 4, 2018
Merged

add rectangle support (rebase version)#1450
sebholstein merged 1 commit into
masterfrom
tim-rectangle

Conversation

@sebholstein

Copy link
Copy Markdown
Owner

closes #1206

@sebholstein

Copy link
Copy Markdown
Owner Author

resolved conflicts, ported tests to Jest

add rectangle functionality

closes #570
@codecov

codecov Bot commented Jul 4, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1450 into master will increase coverage by 2.1%.
The diff coverage is 48.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1450     +/-   ##
=========================================
+ Coverage   26.34%   28.45%   +2.1%     
=========================================
  Files          28       30      +2     
  Lines        1226     1353    +127     
  Branches      159      182     +23     
=========================================
+ Hits          323      385     +62     
- Misses        901      966     +65     
  Partials        2        2
Impacted Files Coverage Δ
packages/core/services/google-maps-types.ts 0% <ø> (ø) ⬆️
packages/core/directives/map.ts 0% <0%> (ø) ⬆️
packages/core/core.module.ts 0% <0%> (ø) ⬆️
packages/core/services/google-maps-api-wrapper.ts 35.13% <25%> (-0.58%) ⬇️
packages/core/directives/rectangle.ts 44.82% <44.82%> (ø)
...ckages/core/services/managers/rectangle-manager.ts 64.7% <64.7%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c76e7e...289d5d4. Read the comment docs.

@sebholstein sebholstein merged commit 2e4878b into master Jul 4, 2018
@ghost ghost deleted the tim-rectangle branch September 17, 2019 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants