Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

Fix: _updateBounds not creating newBounds object#1553

Merged
sebholstein merged 1 commit into
sebholstein:masterfrom
subshock:patch-1
Nov 30, 2018
Merged

Fix: _updateBounds not creating newBounds object#1553
sebholstein merged 1 commit into
sebholstein:masterfrom
subshock:patch-1

Conversation

@subshock

Copy link
Copy Markdown
Contributor

A new LatLngBounds object is required to use the union method immediately afterwards

A new LatLngBounds object is required to use the union method immediately afterwards
@codecov

codecov Bot commented Nov 27, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1553 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1553   +/-   ##
=======================================
  Coverage   28.99%   28.99%           
=======================================
  Files          32       32           
  Lines        1452     1452           
  Branches      197      197           
=======================================
  Hits          421      421           
  Misses       1029     1029           
  Partials        2        2
Impacted Files Coverage Δ
packages/core/directives/map.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa80b87...00b46e5. Read the comment docs.

@sebholstein sebholstein merged commit 0e8f1ab into sebholstein:master Nov 30, 2018
@sebholstein

Copy link
Copy Markdown
Owner

thanks!

@fredgate

Copy link
Copy Markdown

Great. But this is a blocking bug. It will be nice to release a new version ?

@john-hi

john-hi commented Mar 7, 2019

Copy link
Copy Markdown

new google.maps.LatLngBounds(); creates strange bounds (180,1; -180,-1) subsequent newBounds.union(bounds); doesn't mend situation and as result of union we have newBounds equaled (180,1; -180;-1). I don't think it is what we wanted.

Suggest use

var newBounds = new google.maps.LatLngBounds(
    { lat: bounds.south, lng: bounds.west },
    { lat: bounds.north, lng: bounds.east}
);
bounds = newBounds;

or even bounds = { ...bounds }; if we don't need LatLngBounds class functionality

@john-hi

john-hi commented Mar 7, 2019

Copy link
Copy Markdown

as I understand core functionality of project has been in wrong state more then five months. We should fix it ASAP.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants