Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

feat(GoogleMapsAPILoader): change default API version#1577

Merged
sebholstein merged 1 commit into
masterfrom
feat-versioning
Jan 20, 2019
Merged

feat(GoogleMapsAPILoader): change default API version#1577
sebholstein merged 1 commit into
masterfrom
feat-versioning

Conversation

@sebholstein

Copy link
Copy Markdown
Owner

Fixes #1573

This changes the default Google Maps API version to quarterly.

More details about the new versioning schema here: https://developers.google.com/maps/documentation/javascript/versions

@codecov

codecov Bot commented Jan 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1577 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1577   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files          36       36           
  Lines        1531     1531           
  Branches      123      123           
=======================================
  Hits          466      466           
  Misses       1063     1063           
  Partials        2        2
Impacted Files Coverage Δ
...e/services/maps-api-loader/lazy-maps-api-loader.ts 85.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6395d...063b071. Read the comment docs.

This changes the default version of the Google Maps API to `quarterly`
because the Google Maps team changed the version strategy.

BREAKING CHANGES
This could change the Google Maps API version - so please check if you
need to change the setting of the `apiVersion` attribute in the
`AgmCodeModule.forRoot()` call.
@sebholstein sebholstein merged commit 2fc1a21 into master Jan 20, 2019
@ghost ghost deleted the feat-versioning branch September 17, 2019 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant