This repository was archived by the owner on Jun 23, 2025. It is now read-only.
fix(PolylinePoint): prevent accessing undefined variable on change#1597
Merged
4 commits merged intoJun 3, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1597 +/- ##
==========================================
+ Coverage 33.09% 33.35% +0.26%
==========================================
Files 37 37
Lines 1644 1646 +2
Branches 129 131 +2
==========================================
+ Hits 544 549 +5
+ Misses 1098 1095 -3
Partials 2 2
Continue to review full report at Codecov.
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
markmssd
approved these changes
Jun 2, 2019
ghost
approved these changes
Jun 3, 2019
ghost
merged commit 
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug already discussed in the following issue:
#1268
When updating only the latitude or longitude of a PolylinePoint, an error is thrown by ngOnChanges.