Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

feat(cluster): add calculator option#1599

Merged
sebholstein merged 6 commits into
sebholstein:masterfrom
whythecode:feature/calculator
Mar 2, 2019
Merged

feat(cluster): add calculator option#1599
sebholstein merged 6 commits into
sebholstein:masterfrom
whythecode:feature/calculator

Conversation

@whythecode

Copy link
Copy Markdown
Contributor

adds support for defining a custom calculator function

resolves #1510
relates to #1349

@codecov

codecov Bot commented Feb 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1599 into master will increase coverage by 0.21%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
+ Coverage   30.43%   30.64%   +0.21%     
==========================================
  Files          36       36              
  Lines        1531     1540       +9     
  Branches      123      125       +2     
==========================================
+ Hits          466      472       +6     
- Misses       1063     1066       +3     
  Partials        2        2
Impacted Files Coverage Δ
...s/js-marker-clusterer/directives/marker-cluster.ts 0% <0%> (ø) ⬆️
...ker-clusterer/services/managers/cluster-manager.ts 55.07% <47.05%> (+4.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7c97e...1cf4294. Read the comment docs.

@whythecode

Copy link
Copy Markdown
Contributor Author

@SebastianM ich schulde dir einen Kaffee wenn du's bald mergen und deployen kannst :)

@sebholstein

Copy link
Copy Markdown
Owner

thx for the MR. Added some comments. I'm happy to merge it when the comments are addressed

Comment thread packages/js-marker-clusterer/services/managers/cluster-manager.spec.ts Outdated
Comment thread packages/js-marker-clusterer/services/managers/cluster-manager.spec.ts Outdated
Comment thread packages/js-marker-clusterer/services/managers/cluster-manager.spec.ts Outdated
@whythecode

Copy link
Copy Markdown
Contributor Author

awesome, thanks @SebastianM ! the comments have been fixed

@sebholstein sebholstein merged commit 03ceb1c into sebholstein:master Mar 2, 2019
@sebholstein

Copy link
Copy Markdown
Owner

thanks

@whythecode whythecode deleted the feature/calculator branch March 4, 2019 09:40
@whythecode

Copy link
Copy Markdown
Contributor Author

awesome, thanks a lot @SebastianM !

viict pushed a commit to viict/angular-google-maps that referenced this pull request Apr 6, 2019
@whythecode

Copy link
Copy Markdown
Contributor Author

hi @SebastianM , any chance there will be a release the next couple of weeks? would be great if you could just let me know (no matter whether yes or no), so that I can plan accordingly. thanks!!

@popcris8gm

Copy link
Copy Markdown

Hello @SebastianM.

First of all, you did a great job here, awesome!
But I saw you committed the code with 'custom calculator' but it is not released... How exactly I can use it?
I would appreciate your help

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use setCalculator function in agm-marker-cluster

3 participants