Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

fix(FitBounds): correct distinct algorythm#1673

Merged
1 commit merged into
masterfrom
unknown repository
Jul 2, 2019
Merged

fix(FitBounds): correct distinct algorythm#1673
1 commit merged into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jun 30, 2019

Copy link
Copy Markdown

distinctUntilChanged did wrong comparison, causing every element to reevaluate fitBounds on every cycle

@codecov

codecov Bot commented Jun 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1673 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1673   +/-   ##
=======================================
  Coverage   37.55%   37.55%           
=======================================
  Files          37       37           
  Lines        1651     1651           
  Branches      133      134    +1     
=======================================
  Hits          620      620           
  Misses       1029     1029           
  Partials        2        2
Impacted Files Coverage Δ
packages/core/directives/fit-bounds.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0442aa0...2a9c239. Read the comment docs.

@ghost ghost merged commit 75bcfa0 into sebholstein:master Jul 2, 2019
@ghost ghost deleted the fitboundsdistinct branch July 2, 2019 15:35
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant