Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

feat(AgmMap): Add tilesloaded event to AgmMap#1706

Merged
2 commits merged into
sebholstein:masterfrom
CorneeSean:add_tilesloaded_event_to_map
Aug 20, 2019
Merged

feat(AgmMap): Add tilesloaded event to AgmMap#1706
2 commits merged into
sebholstein:masterfrom
CorneeSean:add_tilesloaded_event_to_map

Conversation

@CorneeSean

Copy link
Copy Markdown
Contributor

This pull request exposes 'tilesloaded' event on AgmMap component. GoogleMaps API reference here.
Closes #1701

@codecov

codecov Bot commented Aug 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1706 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1706      +/-   ##
==========================================
- Coverage   39.96%   39.83%   -0.14%     
==========================================
  Files          41       41              
  Lines        1799     1805       +6     
  Branches      154      165      +11     
==========================================
  Hits          719      719              
- Misses       1079     1083       +4     
- Partials        1        3       +2
Impacted Files Coverage Δ
packages/core/directives/map.ts 0% <0%> (ø) ⬆️
...ackages/core/services/managers/polyline-manager.ts 70.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df05277...fdd3519. Read the comment docs.

@CorneeSean

Copy link
Copy Markdown
Contributor Author

From what I see, there are no test files related to AgmMap component so far, hence no tests added by me. This decreases coverage though.

Comment thread packages/core/directives/map.ts Outdated
Comment thread packages/core/directives/map.ts Outdated
Comment thread packages/core/directives/map.ts Outdated
@ghost ghost merged commit d4f1371 into sebholstein:master Aug 20, 2019
@CorneeSean CorneeSean deleted the add_tilesloaded_event_to_map branch August 20, 2019 20:29
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AgmMap component lacks 'tilesloaded' event handler from GoogleMapsAPI

1 participant