fix(GoogleMapsAPIWrapper): run Google Maps Apis outside of Angular#1714
Conversation
Wrap all Google Maps APIs calls in the wrapper with runOutsideAngular Fixes NgZone stability (issue sebholstein#815)
Codecov Report
@@ Coverage Diff @@
## master #1714 +/- ##
==========================================
- Coverage 50.45% 49.86% -0.59%
==========================================
Files 43 43
Lines 1881 1903 +22
Branches 170 170
==========================================
Hits 949 949
- Misses 928 950 +22
Partials 4 4
Continue to review full report at Codecov.
|
ghost
left a comment
There was a problem hiding this comment.
Looks good overall, I'll need to review this more in detail
|
@doom777 any news on this? Can I help you somehow? |
|
@doom777 Would really like to see this as well. I'm adding multiple maps to a page, and there is a performance bottleneck from all the logic being ran inside Angular's zone, which causes change detection to be ran very frequently while the maps are being built. |
|
@doom777 @mpienkowski Hi, any update on this? If this PR won't go through, can I make another? I'd love to see this change. |
Wrap all Google Maps APIs calls in the wrapper with runOutsideAngular
Fixes NgZone stability (issue #815)