This repository was archived by the owner on Jun 23, 2025. It is now read-only.
feat(AgmMarker): add dblclick observable#1739
Merged
1 commit merged intoOct 10, 2019
Merged
Conversation
add and manage double click event for marker fixes sebholstein#1601
Codecov Report
@@ Coverage Diff @@
## master #1739 +/- ##
==========================================
- Coverage 47.73% 47.68% -0.05%
==========================================
Files 41 41
Lines 1835 1839 +4
Branches 167 167
==========================================
+ Hits 876 877 +1
- Misses 955 958 +3
Partials 4 4
Continue to review full report at Codecov.
|
ghost
approved these changes
Oct 10, 2019
|
I see this feature is merged with master. But when I instal the package (via npm), I don't see the changes in the .ts file on my local. My package-lock.json resolves to version 1.0.0 |
|
This will be released in 1.1.0 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add and manage double click event for marker
fixes #1601
I've added the dblclick event from google maps to the AgmMarker directive, following the structure used for the other events. Please note I didn't add any test case, as I wouldn't know what to test for (also, other events do not have a test either).
Let me know if there's something to fix.