This repository was archived by the owner on Jun 23, 2025. It is now read-only.
feat: google map language to default to LOCALE_ID#1754
Merged
3 commits merged intoNov 5, 2019
Merged
Conversation
…le maps should default to angular's LOCALE_ID, andnot en-US
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
==========================================
+ Coverage 49.86% 50.02% +0.15%
==========================================
Files 43 43
Lines 1903 1905 +2
Branches 170 171 +1
==========================================
+ Hits 949 953 +4
+ Misses 950 948 -2
Partials 4 4
Continue to review full report at Codecov.
|
ghost
requested a review
from 
msenosiain
approved these changes
Nov 5, 2019
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the language of google maps should default to angular's LOCALE_ID, and not en-US