fix(Core): Language config bug fixed

[alisahinozcelik]

language config was not working when it is set in forRoot method

[codecov]

Codecov Report

Merging #1775 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1775   +/-   ##
=======================================
  Coverage   47.97%   47.97%           
=======================================
  Files          47       47           
  Lines        1999     1999           
  Branches      177      177           
=======================================
  Hits          959      959           
  Misses       1036     1036           
  Partials        4        4

Impacted Files	Coverage Δ
...e/services/maps-api-loader/lazy-maps-api-loader.ts	89.39% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9e977...727b459. Read the comment docs.

[ghost]

Thanks, I am embarassed as it's my bug.

Can you just add another test showing that when a LOCALE_ID and language are set, it will choose language

[alisahinozcelik]

Thanks, I am embarassed as it's my bug.

Can you just add another test showing that when a LOCALE_ID and language are set, it will choose language

@doom777
Shouldn't it prefer choosing LOCALE_ID in that case. If you say ok, then I can implement that.

[ghost]

No, because LOCALE_ID is always set to be the locale of the entire app. Language is an input you send specifically to Google Maps

[alisahinozcelik]

No, because LOCALE_ID is always set to be the locale of the entire app. Language is an input you send specifically to Google Maps

Ok, I will add that spec.

[erzaehlsalex]

@doom777 Can you please publish a new version with this fix? :)

[shreddison]

please publish :)

[aakici]

@alisahinozcelik, @doom777 please note that the latest commit is not included in the latest npm package. (v1.1.0)

For that reason map language is set always with LOCALE_ID.

Could you please publish a fix. Thank you.