Support data layer#819
Conversation
sebholstein
left a comment
sebholstein
left a comment
There was a problem hiding this comment.
Thanks for the PR. Please add the changes. Then I'm happy to merge it 👍
|
|
||
| let layerId = 0; | ||
|
|
||
| @Directive({ |
There was a problem hiding this comment.
Can you add a description with an example? Please check out the other directives for examples
| /** | ||
| * The geoJson to be displayed | ||
| */ | ||
| geoJson: Object|null = null; |
There was a problem hiding this comment.
when these values can change over time, we have to handle it in ngOnChange. Please check out the other directives.
| setMap(map: GoogleMap): void; | ||
| } | ||
|
|
||
| export interface Feature extends MVCObject { |
There was a problem hiding this comment.
the properties of Feature are missing here: https://developers.google.com/maps/documentation/javascript/reference#Data.Feature
| export interface Feature extends MVCObject { | ||
| } | ||
|
|
||
| export interface DataOptions{ |
There was a problem hiding this comment.
Please add all properties of DataOptions: https://developers.google.com/maps/documentation/javascript/reference#Data.DataOptions
|
Also: please remove the last commit with squashing to have one meaningful commit |
This introduces a new Directive called <sebm-google-map-data-layer> Closes #809
|
I have performed the requested changes. |
|
LGTM, good job! |
2 participants
Support for data layers. These allow GeoJson to be added to the map.
I've only added the most basic functionalities for now.
datalayer example.txt