feat: add animation field to markers by xdimension · Pull Request #852 · sebholstein/angular-google-maps

xdimension · 2017-01-13T05:38:21Z

Feature to set animation for map markers

issue: Add animation field to markers #580

GitCop · 2017-01-13T05:38:22Z

There were the following issues with your Pull Request

Commit: 359af58
Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

sebholstein

Thank you! Added some comments

sebholstein · 2017-01-14T15:51:19Z

+  /**
+   * Which animation to play when marker is added to a map.
+   * This can be "bounce" or "drop"
+   */


Should be animation: "BOUNCE" | "DROP" | null;

sebholstein · 2017-01-14T15:52:56Z

  setOpacity(opacity: number): void;
  setVisible(visible: boolean): void;
  setZIndex(zIndex: number): void;
+  setAnimation(animation: any): void;


LGTM, this way, users can also provide a real google.maps.Animation

sebholstein · 2017-01-14T15:54:58Z


+  updateAnimation(marker: SebmGoogleMapMarker): Promise<void> {
+    return this._markers.get(marker).then((m: Marker) =>
+      m.setAnimation(google.maps.Animation[marker.animation])


this can also be null/undefined:

if (typeof marker.animation === 'string) { m.setAnimation(google.maps.Animation[marker.animation]); } else { m.setAnimation(marker.animation); }

sebholstein · 2017-01-14T15:55:48Z

@@ -73,6 +81,10 @@ export class MarkerManager {
      title: marker.title


please handle the animation here, please handle also null/undefined cases here as above.

sebholstein · 2017-01-14T15:56:02Z

    });
    this._markers.set(marker, markerPromise);
+
+    markerPromise.then((m: Marker) =>


see comment above

Feature to set animation for map markers Updated according to comments in sebholstein#852 issue: Add animation field to markers sebholstein#580

GitCop · 2017-01-22T15:15:57Z

There were the following issues with your Pull Request

Commit: 359af58
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: f4f197c
Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

xdimension · 2017-01-22T15:24:18Z

Sorry for long update, please let me know if there's anything else should be fixed. Thank you.

rhutchison · 2017-01-27T04:31:47Z

@xdimension can you please reword the commit messages and squash so this can get merged. Looking forward to it -- thanks

Feature to set animation for map markers issue: Add animation field to markers sebholstein#580 feat: add animation field to markers Feature to set animation for map markers Updated according to comments in sebholstein#852 issue: Add animation field to markers sebholstein#580

GitCop · 2017-01-29T06:27:25Z

There were the following issues with your Pull Request

Commit: 640e535
Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

rhutchison · 2017-02-11T05:01:23Z

@xdimension thanks for fixing the PR - can you rebase?

@SebastianM can you please get this merged in once he fixes the PR?

Thanks guys

xdimension · 2017-02-11T06:09:54Z

@rhutchison My latest update is as below, I have done the squash. Not sure what I can do next, just let me know if I can help further. Thanks.

rhutchison · 2017-02-11T06:12:27Z

@xdimension it needs to be rebased on top of the latest changes - merge conflicts.

sebholstein · 2017-02-12T15:03:28Z

Can you fix the unit tests? Then I can merge it.

Feature to set animation for map markers issue: Add animation field to markers sebholstein#580

xdimension · 2017-02-13T04:26:09Z

@SebastianM Updated. I'm not really familiar with testing yet, so please review. Thanks.

rbarcelos · 2017-04-30T07:23:10Z

ETA of when will this be available?

seanfar · 2017-06-22T16:15:27Z

@xdimension thanks for your work getting this updated.
@SebastianM any possibility of getting this merged in before next update? Am I mistaken or is it not waiting on anything else? Looking forward to having this feature!

mtszpater · 2017-08-28T13:32:13Z

What's the status of this?

xavier-experion · 2017-09-18T08:41:12Z

Any update on this PR ?

Freshchris01 · 2017-10-25T08:16:09Z

@SebastianM @xdimension Will this feature be merged soon?

orijel · 2017-12-18T10:12:28Z

any updates on this?

wtubog · 2018-01-21T14:41:04Z

Hi, is this feature supported now?

aepgit · 2018-02-08T12:37:34Z

I'm assuming this will be in the next release? Any info on the schedule?

miyelo · 2018-02-23T16:50:41Z

Please please, or just let us access the native google map to add the marker following the google documentation :3
Awesome job

sebholstein suggested changes Jan 14, 2017

View reviewed changes

sebholstein added comp: AgmMarker type: feature labels Jan 14, 2017

xdimension force-pushed the feat-animation branch from f4f197c to 640e535 Compare January 29, 2017 06:27

xdimension force-pushed the feat-animation branch 2 times, most recently from 45a550d to b338c31 Compare January 29, 2017 06:39

lazarljubenovic mentioned this pull request Feb 4, 2017

Animation Marker #884

Closed

xdimension force-pushed the feat-animation branch from b338c31 to f7f483c Compare February 11, 2017 08:07

sebholstein assigned xdimension Feb 12, 2017

feat(AgmMarker): add animation field to markers

d99e292

Feature to set animation for map markers issue: Add animation field to markers sebholstein#580

xdimension force-pushed the feat-animation branch from f7f483c to d99e292 Compare February 13, 2017 04:20

sebholstein closed this in c57ab39 Dec 18, 2017

		@@ -73,6 +81,10 @@ export class MarkerManager {
		title: marker.title

Conversation

xdimension commented Jan 13, 2017

Uh oh!

GitCop commented Jan 13, 2017

Uh oh!

sebholstein left a comment

Choose a reason for hiding this comment

Uh oh!

sebholstein Jan 14, 2017

Choose a reason for hiding this comment

Uh oh!

sebholstein Jan 14, 2017

Choose a reason for hiding this comment

Uh oh!

sebholstein Jan 14, 2017

Choose a reason for hiding this comment

Uh oh!

sebholstein Jan 14, 2017

Choose a reason for hiding this comment

Uh oh!

sebholstein Jan 14, 2017

Choose a reason for hiding this comment

Uh oh!

GitCop commented Jan 22, 2017

Uh oh!

xdimension commented Jan 22, 2017

Uh oh!

rhutchison commented Jan 27, 2017

Uh oh!

GitCop commented Jan 29, 2017

Uh oh!

rhutchison commented Feb 11, 2017

Uh oh!

xdimension commented Feb 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhutchison commented Feb 11, 2017

Uh oh!

sebholstein commented Feb 12, 2017

Uh oh!

xdimension commented Feb 13, 2017

Uh oh!

rbarcelos commented Apr 30, 2017

Uh oh!

seanfar commented Jun 22, 2017

Uh oh!

mtszpater commented Aug 28, 2017

Uh oh!

xavier-experion commented Sep 18, 2017

Uh oh!

Freshchris01 commented Oct 25, 2017

Uh oh!

orijel commented Dec 18, 2017

Uh oh!

wtubog commented Jan 21, 2018

Uh oh!

aepgit commented Feb 8, 2018

Uh oh!

miyelo commented Feb 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

xdimension commented Feb 11, 2017 •

edited

Loading