Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

feat(MarkerManager): set an opacity to marker.#523

Closed
TSHiYK wants to merge 1 commit into
sebholstein:masterfrom
TSHiYK:set-opacity
Closed

feat(MarkerManager): set an opacity to marker.#523
TSHiYK wants to merge 1 commit into
sebholstein:masterfrom
TSHiYK:set-opacity

Conversation

@TSHiYK

@TSHiYK TSHiYK commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@TSHiYK TSHiYK changed the title fix(MarkerManager): set an opacity to marker. refs #522 fix(MarkerManager): set an opacity to marker. Jul 21, 2016
@alexweber

Copy link
Copy Markdown
Contributor

@TSHiYK Looking good! 👍

@sebholstein

Copy link
Copy Markdown
Owner

@TSHiYK thanks! can you change the commit message from fix to feat? Than we can merge it! good job.

@TSHiYK TSHiYK changed the title fix(MarkerManager): set an opacity to marker. feat(MarkerManager): set an opacity to marker. Aug 8, 2016
@TSHiYK

TSHiYK commented Aug 8, 2016

Copy link
Copy Markdown
Contributor Author

@SebastianM Thanks for reply. I fixed the commit message.


/**
* The marker's opacity between 0.0 and 1.0.
*/

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set the default here?: opacity: number = 1;

@sebholstein

Copy link
Copy Markdown
Owner

Sorry, found one more little thing. When the default is 1, we can merge it.

@TSHiYK

TSHiYK commented Aug 8, 2016

Copy link
Copy Markdown
Contributor Author

@SebastianM Done!

@TSHiYK TSHiYK mentioned this pull request Aug 9, 2016
@rojasjandro89

Copy link
Copy Markdown

Any way to animate this opacity other than setInterval?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants