feat(SebmGoogleMap): support draggable map option#556
Conversation
|
Simple enough ... looks good |
|
|
||
| /** | ||
| * Enables/disables if map is draggable. | ||
| */ |
There was a problem hiding this comment.
This attribute name looks good, but the name of the input should be mapDraggable (as we don't want to remap native DOM properties)
There was a problem hiding this comment.
See this example in the marker: https://github.com/SebastianM/angular2-google-maps/blob/master/src/core/directives/google-map-marker.ts#L40
There was a problem hiding this comment.
ahh right, the dom draggable attribute. If someone wants to allow a user to drag a map around on the screen. Good Catch.
http://www.w3schools.com/tags/att_global_draggable.asp
There was a problem hiding this comment.
Nice. so you can have translation on inputs like this?
'draggable: mapDraggable'
mapDraggable would be mapped to the property draggable
There was a problem hiding this comment.
yes, the template would look like this:
<sebm-gogle-map [mapDraggable]="false"></sebm-google-map>
|
@josx thanks! Please address the comments and I'm happy to merge it. |
|
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
Signed-off-by: José Luis Di Biase <josx@interorganic.com.ar>
|
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
… DOM remapping Signed-off-by: José Luis Di Biase <josx@interorganic.com.ar>
|
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
Thanks, merged! |
4 participants
Adding draggable option on map directive.
BTW I need it in my project to no let the user drag on the map.