Skip to content

Updating composer dependencies#114

Merged
pamil merged 5 commits into
Sylius:masterfrom
mamazu:composer
Jan 1, 2020
Merged

Updating composer dependencies#114
pamil merged 5 commits into
Sylius:masterfrom
mamazu:composer

Conversation

@mamazu

@mamazu mamazu commented Nov 28, 2019

Copy link
Copy Markdown
Contributor

The lakion/api-test-case package is now replaced with it's successor.

@lchrusciel lchrusciel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread composer.json Outdated
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
@mamazu

mamazu commented Dec 1, 2019

Copy link
Copy Markdown
Contributor Author

I think the build job failed for some reason. Could you restart it?

@lchrusciel

Copy link
Copy Markdown
Contributor

done

@lchrusciel

Copy link
Copy Markdown
Contributor

Ah, this container was removed from dependencies and added as a suggestion. That's why it's failing.

Ref. https://github.com/lchrusciel/ApiTestCase/blob/master/UPGRADE.md#upgrading-from-v3-to-v4

Comment thread src/Bundle/spec/Controller/RequestConfigurationFactorySpec.php Outdated
@mamazu

mamazu commented Dec 4, 2019

Copy link
Copy Markdown
Contributor Author

@pamil This is the new way of doing things. However to preserve backwards compatibilty the all function that psalm complains about already has documentation like that.

@pamil pamil merged commit 84a8c7a into Sylius:master Jan 1, 2020
@pamil

pamil commented Jan 1, 2020

Copy link
Copy Markdown
Contributor

Thanks, @mamazu! 🎉

@mamazu mamazu deleted the composer branch April 28, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants