Adjust when some runtime deprecation notices are triggered and use Symfony's trigger_deprecation() helper#450
Merged
Conversation
Closed
mbabker
force-pushed
the
less-noisy-deprecations
branch
from
0c243da to
fa7300a
Compare
loic425
approved these changes
May 4, 2022
Member
|
@lchrusciel I think it should be based on bug fix branch (1.9) |
mbabker
force-pushed
the
less-noisy-deprecations
branch
from
fa7300a to
500a389
Compare
…mfony's trigger_deprecation() helper
mbabker
force-pushed
the
less-noisy-deprecations
branch
from
500a389 to
356936d
Compare
Zales0123
added
Enhancement
Zales0123
approved these changes
Oct 18, 2022
Zales0123
left a comment
Zales0123
left a comment
Contributor
There was a problem hiding this comment.
Seems as a good DX improvement 👍
lchrusciel
approved these changes
Oct 18, 2022
Contributor
|
Thank you, @mbabker! 🏅 |
Zales0123
added a commit
that referenced
this pull request
Oct 18, 2022
- [#341](#341) Dropping usage of Request->get ([@loic425](https://github.com/loic425), [@Zales0123](https://github.com/Zales0123)) - [#450](#450) Adjust when some runtime deprecation notices are triggered and use Symfony's trigger_deprecation() helper ([@mbabker](https://github.com/mbabker)) - [#467](#467) [README] Add development section and update links ([@lchrusciel](https://github.com/lchrusciel)) - [#478](#478) Add tests with grids ([@loic425](https://github.com/loic425)) - [#487](#487) Make CsrfTokenManager public ([@Zales0123](https://github.com/Zales0123)) - [#488](#488) Return 422 status code when the form fails ([@belmeopmenieuwesim](https://github.com/belmeopmenieuwesim), [@Zales0123](https://github.com/Zales0123))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will do two things:
trigger_deprecation()helper for runtime deprecations; this is designed to be a "pluggable" function that can allow someone to customize the functionality in their applications if so desired (plus the function's signature forces key information at the front of each message which makes scanning the messages a bit better IMO)