Make CsrfTokenManager public#487
Merged
Merged
Conversation
Zales0123
force-pushed
the
make-csrf-token-manager-public
branch
from
4931044 to
dfeba75
Compare
loic425
approved these changes
Oct 18, 2022
lchrusciel
approved these changes
Oct 18, 2022
| /** | ||
| * TODO Remove on sylius/resource-bundle 2.0 | ||
| */ | ||
| final class CsrfTokenManagerPass implements CompilerPassInterface |
Contributor
There was a problem hiding this comment.
It would be just the art for the sake of art, but we could try to cover this pass with configuration test as well :P
Zales0123
added a commit
that referenced
this pull request
Oct 18, 2022
- [#341](#341) Dropping usage of Request->get ([@loic425](https://github.com/loic425), [@Zales0123](https://github.com/Zales0123)) - [#450](#450) Adjust when some runtime deprecation notices are triggered and use Symfony's trigger_deprecation() helper ([@mbabker](https://github.com/mbabker)) - [#467](#467) [README] Add development section and update links ([@lchrusciel](https://github.com/lchrusciel)) - [#478](#478) Add tests with grids ([@loic425](https://github.com/loic425)) - [#487](#487) Make CsrfTokenManager public ([@Zales0123](https://github.com/Zales0123)) - [#488](#488) Return 422 status code when the form fails ([@belmeopmenieuwesim](https://github.com/belmeopmenieuwesim), [@Zales0123](https://github.com/Zales0123))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We, unfortunately, rely on this service to be public in the
ResourceController:/I've covered the bug with a test (by adding a "delete" button to the test UI) and added explicit Symfony 6.0 and 6.1 testing in the workflow 🖖
Thank you, @dannyvw, for reporting this bug! 🏅