[Maintenance] Out-of-date phpstan/phpdoc-parser conflict removed, docker static analysis memory limit increased#492
Merged
Conversation
Rafikooo
changed the title
NoResponseMate
approved these changes
Oct 26, 2022
TheMilek
approved these changes
Oct 30, 2022
Zales0123
approved these changes
Oct 31, 2022
Contributor
|
Thanks, Rafał! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This conflict mainly causes the problem with the incorrect version (at the moment of creating this PR
alpha(which causes the problem with adding products to the cart) instead ofbeta) installed on the apps that depends on this bundleThe conflicted version is already bumped here:
SyliusLabs/CodingStandard@456379a
==========
This package is struggling with the memory limit on the docker build, in Sylius we have a
php.iniconfig that overrides the default value, here I proposed a simpler solution for adding a flag with an increased memory limit value