Bulk delete#611
Merged
lchrusciel merged 2 commits intoMar 17, 2023
Merged
Conversation
loic425
commented
Feb 20, 2023
loic425
commented
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
loic425
force-pushed
the
feature/bulk-delete
branch
from
5473e6f to
e97d1a3
Compare
loic425
force-pushed
the
feature/bulk-delete
branch
from
f9dc583 to
8ffcbad
Compare
loic425
force-pushed
the
feature/bulk-delete
branch
4 times, most recently
from
de91364 to
fbbc9d6
Compare
loic425
commented
Mar 10, 2023
| } | ||
|
|
||
| public function getId(): ?Uuid | ||
| public function getId(): ?int |
Member
Author
There was a problem hiding this comment.
I've simplified this cause I had some troubles. But it works on a test project with an uuid on a mysql database.
Contributor
There was a problem hiding this comment.
What were the troubles?
Member
Author
There was a problem hiding this comment.
The findById($ids) did not work with SQLite, but I have to check it that again later.
But if there is a bug with that on SQLite, we already have a bug on current implementation.
lchrusciel
reviewed
Mar 10, 2023
Comment on lines
+145
to
+148
| $this->client->request('GET', '/admin/subscriptions'); | ||
| $this->client->submitForm('Bulk delete'); | ||
|
|
||
| $this->assertResponseRedirects(null, expectedCode: Response::HTTP_FOUND); |
Member
Author
There was a problem hiding this comment.
Yes, It checks that the redirect is ok. (it's a code from @Zales0123 on ScienceBookUiTest)
loic425
force-pushed
the
feature/bulk-delete
branch
from
219a7f5 to
735cee2
Compare
lchrusciel
approved these changes
Mar 17, 2023
lchrusciel
added
Feature
Zales0123
added a commit
that referenced
this pull request
Sep 9, 2023
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | fixes #494 | License | MIT Not sure if this is right way to fix the CI When installing doctrine/collections ^2.0 doctrine/persistence ^3.0 and PHP 8.1 should be used. doctrine/collections ^2.0 should not be installed on PHP 8.0 What to do with the psalm errors? Commits ------- 4be530e Allow doctrine/collections ^2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.