Skip to content

Fix Doctrine subscriber deprecations#738

Merged
lchrusciel merged 2 commits into
Sylius:1.11from
loic425:fix/doctrine-subscriber-deprecations
Jul 13, 2023
Merged

Fix Doctrine subscriber deprecations#738
lchrusciel merged 2 commits into
Sylius:1.11from
loic425:fix/doctrine-subscriber-deprecations

Conversation

@loic425

@loic425 loic425 commented Jul 13, 2023

Copy link
Copy Markdown
Member
Q A
Bug fix? yes (deprecations)
New feature? no
BC breaks? no
Deprecations? yes and UPGRADE.md has been updated
Related tickets fixes #736
License MIT

@loic425 loic425 requested a review from a team as a code owner July 13, 2023 08:24
@loic425 loic425 changed the base branch from 1.11 to 1.10 July 13, 2023 08:24
@loic425 loic425 force-pushed the fix/doctrine-subscriber-deprecations branch from 13bb9f0 to 3491746 Compare July 13, 2023 09:10
@loic425 loic425 changed the base branch from 1.10 to 1.11 July 13, 2023 09:10
@loic425

loic425 commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

@lchrusciel Maybe should we keep the public methods for user decorations.

Comment thread src/Bundle/EventListener/ORMRepositoryClassSubscriber.php
use Symfony\Component\DependencyInjection\ContainerInterface;

final class ORMTranslatableListener implements EventSubscriber
final class ORMTranslatableListener

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final class ORMTranslatableListener
final class ORMTranslatableListener implements AbstractDoctrineSubscriber

@loic425 loic425 force-pushed the fix/doctrine-subscriber-deprecations branch from 3491746 to c994b84 Compare July 13, 2023 16:05
@lchrusciel lchrusciel merged commit 8288dbf into Sylius:1.11 Jul 13, 2023
@lchrusciel

Copy link
Copy Markdown
Contributor

Thank you, @loic425!

@loic425 loic425 deleted the fix/doctrine-subscriber-deprecations branch July 13, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symfony 6.3 deprecation doctrine subscribers

3 participants