Skip to content

Commit c73e4a2

Browse files
authored
fix(examples): guard missing filmId param in react star-wars example (#10143)
1 parent c7c0cd9 commit c73e4a2

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

examples/react/star-wars/src/Film.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ import { useQuery } from '@tanstack/react-query'
33
import { getFilm, getCharacter } from './api'
44

55
export default function Film() {
6-
let params = useParams()
7-
const filmId = params.filmId!
6+
const { filmId } = useParams()
7+
8+
if (!filmId) {
9+
return <p>Invalid film ID</p>
10+
}
811

912
const { data, status } = useQuery({
1013
queryKey: ['film', filmId],
@@ -21,7 +24,7 @@ export default function Film() {
2124
<p>{data.opening_crawl}</p>
2225
<br />
2326
<h4 className="text-2xl">Characters</h4>
24-
{data.characters.map((character: any) => {
27+
{data.characters.map((character: string) => {
2528
const characterUrlParts = character.split('/').filter(Boolean)
2629
const characterId = characterUrlParts[characterUrlParts.length - 1]
2730
return <Character characterId={characterId} key={characterId} />

0 commit comments

Comments
 (0)