AboutActivity rewrite#13486
Merged
Merged
Conversation
ShareASmile
added
code quality
The plugin traverses child libraries automatically, so adding it to the parent modules allows us to include dependencies of the whole app and not just the shared part. Configure app and desktopApp to generate the BOM in respective directories of shared module. As iosApp only contains swift, add it's configuration in shared. Also override extractor and evernote's messed up license Generated using: ./gradlew exportLibraryDefinitions Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
It seems the licenses in the generated BOM by aboutlibraries plugin isn't consistent and changes without any reason Licenses were downloaded using reuse tool reuse --root shared/src/commonMain/composeResources/files/ download Apache-2.0 BSD-2-Clause EPL-1.0 GPL-3.0-only GPL-3.0-or-later MIT MPL-2.0 MIT-0 Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
theimpulson
changed the title
Actual pages require Koin to handle callbacks which we don't need during preview. Extract page setup into a parameter and override it to page content during preview. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Member
Author
|
It seems some data like library's developers can be empty as well. {
"uniqueId": "androidx.databinding:viewbinding",
"artifactVersion": "9.2.1",
"name": "androidx.databinding:viewbinding",
"description": "",
"developers": [
],
"licenses": [
"Apache-2.0"
]
}, |
…lable Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Idadelveloper
requested changes
Jun 5, 2026
Idadelveloper
left a comment
Idadelveloper
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes. I have expressed my thoughts and requested some changes. Just to add when I switch to the Licences tab of the about screen and then i scroll the app crashes. Also looks like there is no proper escaping of the \ character in the about and license text.
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Largely inspired from https://insert-koin.io/docs/reference/koin-compose/navigation3/ However I adapted certain things as needed. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
We cannot mark strings as non-translatable in KMP. Remove it and make it a constant in config instead so that the users don't translate it. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Member
Author
Hi, Ida, these all should be fixed. Could you please review again, also the nav3 with Koin commit too. |
Idadelveloper
approved these changes
Jun 8, 2026
Idadelveloper
left a comment
Idadelveloper
left a comment
Contributor
There was a problem hiding this comment.
everything looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence