Skip to content

Commit a96d2cd

Browse files
alambTed-Jiang
authored andcommitted
Minor: Add ticket reference and add test comment (apache#7593)
1 parent 3f75265 commit a96d2cd

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

datafusion/core/tests/sql/mod.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -635,6 +635,9 @@ pub fn make_partition(sz: i32) -> RecordBatch {
635635

636636
/// Specialised String representation
637637
fn col_str(column: &ArrayRef, row_index: usize) -> String {
638+
// NullArray::is_null() does not work on NullArray.
639+
// can remove check for DataType::Null when
640+
// https://github.com/apache/arrow-rs/issues/4835 is fixed
638641
if column.data_type() == &DataType::Null || column.is_null(row_index) {
639642
return "NULL".to_string();
640643
}

datafusion/optimizer/src/analyzer/type_coercion.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -881,6 +881,7 @@ mod test {
881881

882882
#[test]
883883
fn scalar_function() -> Result<()> {
884+
// test that automatic argument type coercion for scalar functions work
884885
let empty = empty();
885886
let lit_expr = lit(10i64);
886887
let fun: BuiltinScalarFunction = BuiltinScalarFunction::Acos;

0 commit comments

Comments
 (0)