feat(eslint-config): remove no-unnecessary-condition rule

Author: dangreen

packages/eslint-config/src/jest.js

@@ -40,7 +40,6 @@ module.exports = {
         'no-loop-func': 'off',
         '@typescript-eslint/no-misused-promises': 'off',
         '@typescript-eslint/no-empty-function': 'off',
-        '@typescript-eslint/no-unnecessary-condition': 'off',
         '@typescript-eslint/naming-convention': 'off'
       }
     }

packages/eslint-config/src/rules/typescript-requiring-type-checking.js

@@ -11,14 +11,6 @@ module.exports = {
     '@typescript-eslint/no-base-to-string': 'error',
     '@typescript-eslint/no-throw-literal': 'error',
     '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
-    '@typescript-eslint/no-unnecessary-condition': [
-      // https://github.com/typescript-eslint/typescript-eslint/issues/2333 : `strictNullChecks` compiler option needed
-      // `strictNullChecks` is very strcit (┛◉Д◉)┛彡┻━┻
-      'error',
-      {
-        allowConstantLoopConditions: true
-      }
-    ],
     '@typescript-eslint/no-unnecessary-qualifier': 'error',
     '@typescript-eslint/no-unnecessary-type-arguments': 'error',
     '@typescript-eslint/prefer-includes': 'error',